improve documentation and add check for doc coverage regression #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imobachgs
reviewed
Jul 11, 2019
teclator
reviewed
Jul 11, 2019
| @@ -3,4 +3,6 @@ require "yast/rake" | |||
| Yast::Tasks.configuration do |conf| | |||
| # lets ignore license check for now | |||
| conf.skip_license_check << /.*/ | |||
| # ensure we are not getting worse with documentation | |||
| conf.documentation_minimal = 61 if conf.respond_to?(:documentation_minimal=) | |||
teclator
reviewed
Jul 11, 2019
mchf
reviewed
Jul 11, 2019
mchf
reviewed
Jul 11, 2019
mchf
reviewed
Jul 11, 2019
mchf
reviewed
Jul 11, 2019
mchf
reviewed
Jul 19, 2019
| def abort_button | ||
| Yast::Label.CancelButton | ||
| end | ||
|
|
||
| # removes back button when editing device, but keep it when this dialog is | ||
| # followed by add followed add |
There was a problem hiding this comment.
to many followed ;-)
May be I'd change it to something like "keep it when this dialog follows adding new interface"
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.