Config proposal #935
Merged
Config proposal #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imobachgs
reviewed
Sep 2, 2019
| @@ -59,10 +59,39 @@ class Base | |||
| # Constructor | |||
| def initialize | |||
| @ip_aliases = [] | |||
| @bootproto = BootProtocol::STATIC | |||
| @bootproto = BootProtocol::STATIC # TODO: maybe do test query if psycical interface is attached? | |||
| def propose | ||
| super | ||
| # For WIFI DHCP makes more sense as majority of wifi routers act as dhcp servers | ||
| self.bootproto = BootProtocol::DHCP |
There was a problem hiding this comment.
What is exactly the difference between above attributes and this one? For instance, between self.mode and self.bootproto. Please, document it in the #propose method description so we know where to put each of them.
imobachgs
approved these changes
Sep 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.