Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "ntp-client" return value for SLE 15 SP1 #139

Merged
merged 11 commits into from
Jul 5, 2019

Conversation

imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Jul 5, 2019

Bring #139 to SLE-15-SP1.

@imobachgs imobachgs force-pushed the fix/ntp-client-return-value-sle-15-sp1 branch from e45975b to 85869dc Compare July 5, 2019 11:08
* SLE-15-GA:
  Bump version and update changes file
  Fix Dialog::Main buttons when no running in normal/config mode
  Fix ntp-client return value when running in firstboot stage
  Unified bug number reference
  Bump version & changelog
@imobachgs imobachgs force-pushed the fix/ntp-client-return-value-sle-15-sp1 branch from 85869dc to 2a2749a Compare July 5, 2019 11:08
Copy link
Member

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/lib/y2ntp_client/dialog/main.rb Outdated Show resolved Hide resolved
Copy link
Member

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imobachgs imobachgs merged commit 384cd34 into SLE-15-SP1 Jul 5, 2019
@imobachgs imobachgs deleted the fix/ntp-client-return-value-sle-15-sp1 branch July 5, 2019 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants