-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Coveralls code coverage report. #166
Conversation
add_filter "/test/" | ||
end | ||
|
||
# For coverage we need to load all ruby files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And that makes the test fail with
/usr/lib/ruby/vendor_ruby/2.1.0/yast/yast.rb:168:in `import_pure': component cannot import namespace 'SLP' (NameError)
from /usr/lib/ruby/vendor_ruby/2.1.0/yast/yast.rb:168:in `import'
from /home/travis/build/yast/yast-packager/src/modules/SourceManagerSLP.rb:19:in `main'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked around a few lines below here
Changes Unknown when pulling ce3987e on coveralls into * on master*. |
Changes Unknown when pulling 1a52fa4 on coveralls into * on master*. |
Changes Unknown when pulling 0159c67 on coveralls into * on master*. |
@mvidner still failing, will you fix it? |
I have found the problem with the tests, I'm fixing this. |
cc4cf9d
to
c9a97eb
Compare
Changes Unknown when pulling c9a97eb on coveralls into on master. |
@@ -5,10 +5,11 @@ before_install: | |||
# disable rvm, use system Ruby | |||
- rvm reset | |||
- wget https://raw.githubusercontent.com/yast/yast-devtools/master/travis-tools/travis_setup.sh | |||
- sh ./travis_setup.sh -p "yast2-devtools yast2-testsuite yast2 yast2-pkg-bindings yast2-country-data yast2-storage" -g rspec:3.3.0 | |||
- sh ./travis_setup.sh -p "rake yast2-devtools yast2-testsuite yast2 yast2-pkg-bindings yast2-country-data yast2-storage" -g "rspec:3.3.0 yast-rake simplecov:0.10.0 coveralls" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you try it again with the latest simplecov
gem? I'd like to avoid freezing that gem if possible...
so as not to mess up other tests by leaving SCR switched to our own root
This is because this file was omitted from the list of tests when #185 was merged.
Changes Unknown when pulling 73e60c1 on coveralls into * on master*. |
Thanks for the tips! Applied. |
LGTM, thanks! |
https://coveralls.io/github/yast/yast-packager
Also added one forgotten file to the list of tests executed at rpm build.