Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Coveralls code coverage report. #166

Merged
merged 5 commits into from
Sep 1, 2016
Merged

Enable Coveralls code coverage report. #166

merged 5 commits into from
Sep 1, 2016

Conversation

mvidner
Copy link
Member

@mvidner mvidner commented Jun 20, 2016

https://coveralls.io/github/yast/yast-packager

Also added one forgotten file to the list of tests executed at rpm build.

add_filter "/test/"
end

# For coverage we need to load all ruby files
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And that makes the test fail with

/usr/lib/ruby/vendor_ruby/2.1.0/yast/yast.rb:168:in `import_pure': component cannot import namespace 'SLP' (NameError)
    from /usr/lib/ruby/vendor_ruby/2.1.0/yast/yast.rb:168:in `import'
    from /home/travis/build/yast/yast-packager/src/modules/SourceManagerSLP.rb:19:in `main'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked around a few lines below here

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ce3987e on coveralls into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 1a52fa4 on coveralls into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0159c67 on coveralls into * on master*.

@jreidinger
Copy link
Member

@mvidner still failing, will you fix it?

@mvidner
Copy link
Member Author

mvidner commented Aug 31, 2016

I have found the problem with the tests, I'm fixing this.

@mvidner mvidner force-pushed the coveralls branch 2 times, most recently from cc4cf9d to c9a97eb Compare August 31, 2016 15:22
@coveralls
Copy link

coveralls commented Aug 31, 2016

Coverage Status

Changes Unknown when pulling c9a97eb on coveralls into on master.

@@ -5,10 +5,11 @@ before_install:
# disable rvm, use system Ruby
- rvm reset
- wget https://raw.githubusercontent.com/yast/yast-devtools/master/travis-tools/travis_setup.sh
- sh ./travis_setup.sh -p "yast2-devtools yast2-testsuite yast2 yast2-pkg-bindings yast2-country-data yast2-storage" -g rspec:3.3.0
- sh ./travis_setup.sh -p "rake yast2-devtools yast2-testsuite yast2 yast2-pkg-bindings yast2-country-data yast2-storage" -g "rspec:3.3.0 yast-rake simplecov:0.10.0 coveralls"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try it again with the latest simplecov gem? I'd like to avoid freezing that gem if possible...

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 73e60c1 on coveralls into * on master*.

@mvidner
Copy link
Member Author

mvidner commented Sep 1, 2016

Thanks for the tips! Applied.

@lslezak
Copy link
Member

lslezak commented Sep 1, 2016

LGTM, thanks!

@mvidner mvidner merged commit dff4982 into master Sep 1, 2016
@mvidner mvidner deleted the coveralls branch September 1, 2016 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants