Added version:wbump task #31
Conversation
A task which bumps version and creates a wrapper class for accessing version in the project.
| next if !File.directory?(filename) | ||
|
|
||
| module_name = File.basename(filename).downcase | ||
| target_file = "#{module_name}_version.rb" |
There was a problem hiding this comment.
The usual convention for a version file is to use version.rb, see find /usr/lib64/ruby/gems/ -name "*version*.rb".
There was a problem hiding this comment.
well, I just wanted to customize the file name per package
|
And what's actually the purpose of the task? Where do you plan to use it? BTW why |
|
wbump == "write bumped version" ... If you have a better idea, I'm open ;-) |
|
My main motivation was to write package version into logs to see what version of package customer uses (support config is not always awailable, ...) |
|
@mchf well, if you use save_y2logs, it contains also output of rpm -qa which have version of all packages, so you do not need support config. save_y2logs is enough. |
|
In general I do not like this pull request. It adds another duplicite location. We have in past problem that we have two files with version. Now only authoritative one is spec file, so it should be used from there and not having two sources of info again. If you need access to version in source code, I suggest to add to yast2 class that get used yast module version like |
|
In earlier times there were |
|
Neither I like the version duplication. And using another non-standard task for version bumping is wrong. I bet somebody will use simple
I'd suggest just closing the PR without merging, sorry... |
|
so lets close it |
For bumping and creating a helper class for accessing package version within the code.