Return false when a json error happens

yast · Mar 13, 2019 · ba1d1e0 · ba1d1e0
1 parent 986dd74
commit ba1d1e0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/lib/registration/connect_helpers.rb b/src/lib/registration/connect_helpers.rb
@@ -142,6 +142,7 @@ def self.catch_registration_errors(message_prefix: "",
         # update the message when an old SMT server is found
         check_smt_api(e.message)
         details_error(message_prefix + _("Cannot parse the data from server."), e.message)
+        false
       rescue StandardError => e
         log.error("SCC registration failed: #{e.class}: #{e}, #{e.backtrace}")
         Yast::Report.Error(

diff --git a/src/lib/registration/registration_ui.rb b/src/lib/registration/registration_ui.rb
@@ -55,7 +55,7 @@ def initialize(registration)
     def register_system_and_base_product
       product_service = nil
       # TRANSLATORS: Popup error message prefix
-      error_options = { message_prefix: _("Registration failed.") }
+      error_options = { message_prefix: _("Registration failed.") + "\n\n" }
 
       success = ConnectHelpers.catch_registration_errors(error_options) do
         register_system if !Registration.is_registered?