Forbid using CRLF in the reg. code (bsc#1111419) #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lslezak
commented
Oct 11, 2018
lslezak
commented
- Forbid using CRLF in the reg. code they cannot be included in the registration code
- The code is sent in the HTTP header which does not allow using CRLF, it is used as header field separator.
- Normally you cannot enter a new line character into the input field but you can copy & paste it by mistake with the registration code
- 3.2.17
they cannot be included in the registration code - 3.2.17
imobachgs
reviewed
Oct 11, 2018
| # include CRLF characters which are not allowed | ||
| let(:reg_code) { "\nmy-reg-code\r" } | ||
| it "displays error popup and does not register the system" do | ||
| expect(Yast::UI).to receive(:QueryWidget).with(:reg_code, :Value) |
There was a problem hiding this comment.
np: IMHO, you are not testing this, so I would use allow here to make it clear. The same for the next two lines.
| expect(Yast::UI).to receive(:UserInput).and_return(:next, :abort) | ||
| expect(Registration::UI::AbortConfirmation).to receive(:run).and_return(true) | ||
|
|
||
| expect(Yast::Report).to receive(:Error).with(/Invalid registration code/) |
There was a problem hiding this comment.
This (and the next line) is what you really want to test. So it is fine to use expect here.
imobachgs
approved these changes
Oct 11, 2018
imobachgs
approved these changes
Oct 11, 2018
|
✔️ Internal Jenkins job #6 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.