Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce full coverage #40

Closed
wants to merge 1 commit into from
Closed

Enforce full coverage #40

wants to merge 1 commit into from

Conversation

ikapelyukhin
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 412

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.83%
Totals Coverage Status
Change from base Build 409: 0.0%
Covered Lines: 611
Relevant Lines: 631
💛 - Coveralls

@ngetahun
Copy link
Collaborator

Created a card for this here

@dgdavid
Copy link
Member

dgdavid commented Jul 28, 2021

Hi @ngetahun!

I'm reviewing old and open PRs in YaST modules and just wondering if you plan to continue moving this one ahead or just it's time for closing it.

What do you think?

@dgdavid
Copy link
Member

dgdavid commented Sep 13, 2021 •
edited
Loading

Ok, I'll mark it as draft to stop receiving notification about this until it is ready again. Thanks for understanding it.

@dgdavid dgdavid marked this pull request as draft September 13, 2021 12:24
@felixsch
Copy link
Collaborator

While this is a good idea: We do not work regularly on this project and nobody will currently find the time to adapt tests to have 100% coverage.

I will close this for now, since we already have a card in our backlog about this.

@felixsch felixsch closed this Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ikapelyukhin @coveralls @ngetahun @dgdavid @felixsch