Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby27 #241

Merged
merged 3 commits into from
Apr 22, 2020
Merged

Ruby27 #241

merged 3 commits into from
Apr 22, 2020

Conversation

jreidinger
Copy link
Member

waiting for branching of SP2

bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1169442#c2

mvidner
mvidner approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@mvidner mvidner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The important companion to this PR are the existing unit tests for Builtins.tointeger:

yast-ruby-bindings/tests/builtins_casts_spec.rb

Line 82 in 4288ac4

describe ".tointeger" do
and they are good enough.

@jreidinger
Copy link
Member Author

@mvidner yes, I use it a lot for testing. Thanks

@jreidinger jreidinger marked this pull request as ready for review April 22, 2020 06:56
@jreidinger jreidinger merged commit c20e9e3 into master Apr 22, 2020
@jreidinger jreidinger deleted the ruby27 branch April 22, 2020 09:38
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #22 successfully finished
✔️ Created OBS submit request #796248

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #14 successfully finished
✔️ Created IBS submit request #224059

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvidner mvidner mvidner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jreidinger @yast-bot @mvidner