Changed handling of unformatted DASD devices during autoinstallation (fate#313228)

[jsrain]

Unfortunately, I could not test the code until having an S/390 build...
Changelog entry comes later

[jsrain]

I have added FIXMEs on activation error handling - so that overall exist code is returned. It is not that trivial, since a more inteligent error handling would need to be added (in case of multiple disks returning different exit codes).

[kobliha]

What's the status of this review?

[jsrain]

I hope that I answered Arvin's question (there was no error handling, so no regression, and doing it properly IMO means proper handling of error and non-error, but still non-zero exit codes - which should be handled separately from this enhancement).

[kobliha]

@aschnell See above, what's the verdict?

[aschnell]

Is it tested? I don't see any documentation update.

[jsrain]

I have enhanced it in regard of other related features. The testing was only limited, due to the overall status of the S/390 snapshots.

[jreidinger]

hmm, why eight? constant will be better here

[jsrain]

adding a comment explaining the number

[jreidinger]

I found some ruby issues, but nothing critical, so if you are under pressure by feature freeze you can improve it after it.

[kobliha]

@jreidinger Thanks, we need these S390 features to be done till feature freeze, let's add what needs to be done "better" into, e.g. Trello. Real issues should be fixed before merging, fixing cosmetic issues should be delayed after FF.

[jreidinger]

OK, I expect some cleaning when we get proper s390. LGTM