Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YaPI::Samba: Drop unused GetServiceStatus() method. #69

Closed
wants to merge 1 commit into from
Closed

YaPI::Samba: Drop unused GetServiceStatus() method. #69

wants to merge 1 commit into from

Conversation

teclator
Copy link
Contributor

@teclator teclator commented Nov 11, 2019 •
edited

jreidinger
jreidinger reviewed Nov 11, 2019
View reviewed changes
src/modules/YaPI/Samba.pm

returns true if the services smbd and nmbd are enabled, false if either of
them is disabled or undef on failure.

$enabled = EditService($enable)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here it use previous $enable

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe mark in doc that the YAPI is deprecated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here it use previous $enable

And also in other methods.

Probably we should, but what to do with old testsuite? Drop them completely or adapt them

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, then in this example use e.g. true here.

I am not sure about old testsuite. Can we keep it without big investments? if so, then I would keep it, otherwise I think it is fine to drop it.

@teclator teclator mentioned this pull request Nov 11, 2019
Merged
@teclator
Copy link
Contributor Author

Replaced by #70

@teclator teclator closed this Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreidinger jreidinger jreidinger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teclator @jreidinger