Fix YaPI-GetServiceStatus failing old testsuite #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teclator
changed the title
imobachgs
approved these changes
Nov 28, 2019
lslezak
approved these changes
Nov 28, 2019
|
✔️ Public Jenkins job #15 successfully finished |
|
✔️ Internal Jenkins job #6 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
YaPI-GetServiceStatustest started to fail because of this PR where basically an import of 'Systemd' was added.SystemdimportsFileUtilswhich importsPopupwhich importsDirectory.Solution
The issue could be solved in yast2 moving the
Systemdimport to the method which uses it, returning without importing in case ofMode.testsuite, but, as it is consequence ofYaPIand a old testsuite, will just do an earlier import in the failing test. If we see that it affects other tests in other modules then it will be done also in yast2