Ensure nmbd is restarted following nmbstatus lookup #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Abandoning, per the discussion in bsc#1158916, it is no longer necessary to stop nmbd when running nmbstatus and so a better fix is to remove that code from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the YaST samba-server module is started, it stops the nmb service to run nmbstatus but does not always start is again as it should.
The following happens:
yast-samba-server/src/modules/SambaServer.pmcallsSambaNmbLookup->Start()fromyast-samba-client/src/modules/SambaNmbLookup.pm.SambaNmbLookup.pmstops the nmb service and asynchronously starts nmbstatus.SambaNmbLookup->checkNmbstatus()to ensure nmbstatus completed and nmbd can be started again.This is bsc#1158916. Issue bsc#895319 was a similar problem but in yast-samba-client and got fixed by yast/yast-samba-client#32. The patch here takes the same approach.