Use Docker at Travis #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchf
reviewed
Jan 19, 2017
|
|
||
| # the "yast-travis-cpp" script is included in the base yastdevel/cpp image | ||
| # see https://github.com/yast/docker-yast-cpp/blob/master/yast-travis-cpp | ||
| - docker run -it -e TRAVIS=1 -e TRAVIS_JOB_ID="$TRAVIS_JOB_ID" yast-slp-image yast-travis-cpp |
There was a problem hiding this comment.
ok, i'm just curios when is yast-travis-cpp preferred over *-ruby one. As this module contains more then 50% of code written in ruby it is not that clear.
There was a problem hiding this comment.
Oh, good point I'll switch to the Ruby image...
mchf
reviewed
Jan 19, 2017
| RUN zypper --gpg-auto-import-keys --non-interactive in --no-recommends \ | ||
| openslp-devel \ | ||
| yast2 \ | ||
| yast2-ruby-bindings |
There was a problem hiding this comment.
so it seems, that this package requires some more packages in docker's image ... Isn't that an issue in the package's dependencies?
There was a problem hiding this comment.
No, I just want to avoid installing these specific packages for all the other YaST modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.