Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The logic for adding _netdev needs to be refined... once again!
Now we have been told that
_netdev
should be skipped not only for "/" and all its subvolumes, but also for all the mount points that are based on the same disk than "/".See https://bugzilla.suse.com/show_bug.cgi?id=1176140
Partial Solution
This expands the logic of
#set_default_mount_options
to honor the new proposed (and approved) logic described here:https://gist.github.com/ancorgs/435328f6f16920a17b0b8cca7500526e#proposed-rspec-output-for-y2storagemountpoint
Unfortunately, this is only a solution if the root mount point is the first to be created. For example, imagine we create a mount point for "/var" in sda2. In that moment,
#set_default_mount_options
will add _netdev to it since there is no evidence of that partition being in the root disk. If at a later point, sda3 is created and mounted as "/", the mount options of sda2 will not be re-adjusted (so far, we have never needed to adjust the options of one mount point based on the presence of another one, so we have no such mechanism).Testing
Do not merge
We need a definitive solution.