Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encrypt: Fix UI message typo, loose->lose #1253

Merged
merged 2 commits into from Nov 24, 2021
Merged

encrypt: Fix UI message typo, loose->lose #1253

merged 2 commits into from Nov 24, 2021

Conversation

ghost
Copy link

@ghost ghost commented Nov 23, 2021

Problem

A typo in a UI message.

Solution

Typo fixed. (I also slightly reworded the message below.)

Testing

  • Not tested but trivial, I guess

Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it! The changes look ok to me, but the version should be bumped. Otherwise, the request will be rejected by our boots. Moreover, a new changelog entry is missing. Please, also add this reference in the changelog: "(part of jsc#SLE-21308)" .

@ghost
Copy link
Author

ghost commented Nov 23, 2021

@joseivanlopez Thanks for the quick feedback, all fixed now I hope. (I also noticed that for some reason my branch was ~19 commits behind master ... not sure why--in any case, I rebased on top of master.)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.721% when pulling bb80766 on sknorr:lose into 2186225 on yast:master.

Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseivanlopez joseivanlopez merged commit 0772b76 into yast:master Nov 24, 2021
@joseivanlopez
Copy link
Contributor

Merged, thanks!!

@yast-bot
Copy link

❌ Public Jenkins job #393 failed

@yast-bot
Copy link

✔️ Public Jenkins job #394 successfully finished
✔️ Created OBS submit request #933436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants