Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import mount point from multi-device Btrfs #933

Merged
merged 3 commits into from
Jul 1, 2019

Conversation

joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Jun 21, 2019

Problem

The Expert Partitioner has a feature to import mount points from the fstab file of a previous installation. When an imported fstab entry points to a multi-device Btrfs in the previous system, the multi-device filesystem is not restored in the new system being installed. Instead of that, a single-device Btrfs is created.

Solution

Now on, the multi-device Btrfs is re-created in the new system when importing the mount point.

Testing

  • Added unit tests
  • Tested manually

Screenshots

Show screenshots
  • Storage layout from the initial proposal:

VirtualBox_SLE-15-2_21_06_2019_12_12_44

  • Importing mount points from a previous system with multi-device Btrfs:

VirtualBox_SLE-15-2_21_06_2019_12_13_27

  • Result after importing mount points:

VirtualBox_SLE-15-2_21_06_2019_12_13_42

@coveralls
Copy link

coveralls commented Jun 21, 2019

Coverage Status

Coverage increased (+0.002%) to 97.584% when pulling 37d2f27 on joseivanlopez:fix_import_mount_points into a0cb655 on yast:master.

@joseivanlopez joseivanlopez marked this pull request as ready for review June 21, 2019 11:49
Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseivanlopez joseivanlopez merged commit d5a9547 into yast:master Jul 1, 2019
@yast-bot
Copy link

yast-bot commented Jul 1, 2019

✔️ Public Jenkins job #179 successfully finished
✔️ Created OBS submit request #712901

@yast-bot
Copy link

yast-bot commented Jul 1, 2019

✔️ Internal Jenkins job #5 successfully finished
✔️ Created IBS submit request #195806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants