now SR number can be longer then 11 as we already eat that numbers, s… #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce branch SLE-12-SP2
…o relax condition
kobliha
reviewed
Jun 16, 2017
src/include/support/dialogs.rb
Outdated
| @@ -771,7 +771,7 @@ def ContactDialog | |||
| Left( | |||
| InputField( | |||
| Id(:novell_number), | |||
| _("11-digit service request number"), | |||
| _("service request number"), | |||
There was a problem hiding this comment.
Oops, I guess capital "S" needed here
kobliha
reviewed
Jun 16, 2017
src/include/support/dialogs.rb
Outdated
| if Builtins.size(Support.novell_number) != 11 | ||
| Popup.Error(_("The SR number must be 11 digits")) | ||
| if Builtins.size(Support.novell_number) < 11 | ||
| Popup.Error(_("The SR number must be at least 11 digits")) |
There was a problem hiding this comment.
I'd myself use "service request" instead of SR
(unified with other places)
kobliha
requested changes
Jun 16, 2017
Rakefile
Outdated
| @@ -1,5 +1,7 @@ | |||
| require "yast/rake" | |||
|
|
|||
| Yast::Tasks.submit_to :sle12sp2 | |||
There was a problem hiding this comment.
Looks weird, master is ... SLE 12 SP3 or SLE 15 now, not SLE 12 SP2
…maintenance branch SLE-12-SP2" This reverts commit 2f3a285.
kobliha
approved these changes
Jun 16, 2017
|
LGTM, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix confirmed