Do not restore old backups when upgrade fails #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lslezak
reviewed
Sep 14, 2018
| log.info "Restoring with script #{cmd} result: #{res}" | ||
| backup_time = File.stat(path).ctime.to_i | ||
|
|
||
| if boot_time < backup_time |
There was a problem hiding this comment.
I'm not sure if this works on platforms without RTC (e.g. Raspberry Pi). If without RTC the boot time is always 0 then the backup would be always restored. We should check that.
src/modules/Update.rb
Outdated
| @@ -850,6 +859,11 @@ def restore_backup | |||
|
|
|||
| private | |||
|
|
|||
| # @return [Integer] boot time found in /proc/stat | |||
| def boot_time | |||
| @boot_time ||= IO.read("/proc/stat")[/btime.*/].split.last.to_i | |||
There was a problem hiding this comment.
It would be nice to add a test for parsing the file, the added test mocks the method completely so it's skipped.
dgdavid
force-pushed
the
fix/bsc-1097297
branch
from
58f3339
to
107bb45
Compare
dgdavid
force-pushed
the
fix/bsc-1097297
branch
from
107bb45
to
2ae09b3
Compare
|
Closed in favor of #111 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://bugzilla.suse.com/show_bug.cgi?id=1097297