Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a Linux::BaseReader #286

Merged
merged 4 commits into from
May 28, 2021
Merged

Adds a Linux::BaseReader #286

merged 4 commits into from
May 28, 2021

Conversation

dgdavid
Copy link
Member

@dgdavid dgdavid commented May 28, 2021

For allocating shared logic between Linux::LocalReader and Linux::Reader, as commented in #280 (comment)

For allocating shared logic between Linux::LocalReader and Linux::Reader
@coveralls
Copy link

coveralls commented May 28, 2021

Pull Request Test Coverage Report for Build 885803719

  • 60 of 60 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 46.882%

Totals Coverage Status
Change from base Build 882714568: -0.04%
Covered Lines: 2060
Relevant Lines: 4394

💛 - Coveralls

Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgdavid dgdavid merged commit 2f0f785 into y2users May 28, 2021
@dgdavid dgdavid deleted the linux-base-reader branch May 28, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants