Extend Linux writer #323
Merged
Extend Linux writer #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1124306811
💛 - Coveralls |
joseivanlopez
force-pushed
the
edit-username
branch
from
a93f983
to
95bede3
Compare
shundhammer
reviewed
Aug 12, 2021
dgdavid
approved these changes
Aug 12, 2021
Comment on lines
+105
to
+107
| # FIXME: Validation methods should only check values. Note that with the current implementation, | ||
| # this method is taking care of setting/removing the user's password. This method should not | ||
| # modify the user. |
|
✔️ Public Jenkins job #63 successfully finished |
|
✔️ Internal Jenkins job #25 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Right now, the
Linux::Writerclass only supports (auto)installation and firstboot use cases. During the installation, users can only be created. And for firstboot and auto-installation, users can be edited too. In firstboot, even the name of the user can be changed when you go back, but theLinux::Writerdoes not modify it in the system.Moreover, the root password is not properly deleted if you go back to the wizard step for setting the root password and remove password (only an authorized key is selected). This affects to both: installation and firstboot.
Solution
Extend
Linux::Writerin order to support the use cases mentioning above.See also yast/yast-firstboot#127.
Testing