Added extra attributes to allow customizing the fab speed dial control more. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 11, 2016 10:52
… sizes for the mini fab title view. Also fixed an issue where I had messed up some styles.xml related values (i.e. set contentPaddingBottom to the mini fab label elevation value) - silly mistake on my part, but that's been corrected. In general, I removed styles values that are set in the code since they'll be overridden anyway and may be confusing if kept in.
…b list to appear closer to the main fab.
…the newly added customization capabilities.
…iew was being given a larger left and right margin (left for controls using a start gravity, right for end gravity) than necessary. Using 0dp for the pre-Lollipop coordinator_layout_offset results in no extra margin being added and the mini FABs line up with the main FAB correctly.
… rather than just a top margin. This results in even spacing between the main FAB and the first mini FAB for controls that use top and bottom layout gravity. Also updated the fab_menu_item_start layout xml to use the MiniFabLayout style.
Also removed sample projects' fab_margin value which was overriding the library version, resulting in unexpected behavior for users of the library who are not aware that the margin values of the control are being changed to the value defined in the fab_margin of the sample projects. I ran into this when I was trying to understand why the FAB margins were different than what another sample project was using for a standard FloatingActionButton - in both cases no margin_layout values were being set, but in the sample for this library the margins were consistently different (on pre-Lollipop devices at least, where we used 12dp in the sample but 0dp in the library!)
…is fixes any instances where applications which use this library may override one of these values inexplicably. For example, if fab_margin is used for the FAB layout margin value, any value that apps use for fab_margin will override the value used in the library. Renaming the values ensures no one "accidentally" overrides a value unless they are specifically trying to!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed some layout/margin values for pre-Lollipop devices.