Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix same location update calls #65

Merged
merged 2 commits into from
Aug 18, 2017
Merged

Fix same location update calls #65

merged 2 commits into from
Aug 18, 2017

Conversation

yayaa
Copy link
Owner

@yayaa yayaa commented Aug 17, 2017

To retrieve the location for the first time, library requests location update as minTimeInterval 0 and this might cause some multiple calls for onLocationChanged even though it actually doesn't.

This adapts the logic to remove update request once onLocationChanged is called, and re-schedule with required time & distance intervals if only keepTracking required.

Issue: #64

@yayaa yayaa added this to the v2.0.4 milestone Aug 17, 2017
@codecov-io
Copy link

codecov-io commented Aug 17, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@7aa9d85). Click here to learn what that means.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #65   +/-   ##
=========================================
  Coverage          ?   66.91%           
=========================================
  Files             ?       31           
  Lines             ?     1070           
  Branches          ?       91           
=========================================
  Hits              ?      716           
  Misses            ?      295           
  Partials          ?       59
Impacted Files Coverage Δ
...yandroid/locationmanager/helper/UpdateRequest.java 0% <0%> (ø)
...ders/locationprovider/DefaultLocationProvider.java 87.5% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aa9d85...4a70818. Read the comment docs.

@yayaa yayaa merged commit fed8d3b into master Aug 18, 2017
@yayaa yayaa deleted the yb/same_location_update_fix branch August 18, 2017 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants