Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add set_labels method #21

Merged
merged 6 commits into from
Jun 18, 2024
Merged

feat: add set_labels method #21

merged 6 commits into from
Jun 18, 2024

Conversation

yazdipour
Copy link
Owner

@yazdipour yazdipour commented Jun 17, 2024

ℹ Additional Information

Summary by Sourcery

This pull request adds a new method set_labels to the omnivoreql module, enabling the setting of labels for a page. It also includes a corresponding test to validate the new functionality.

  • New Features:
    • Introduced a new method set_labels to set labels for a page, allowing the specification of label IDs and label details.
  • Tests:
    • Added a test case test_set_labels to verify the functionality of the new set_labels method, ensuring it correctly sets labels for a given page.

Copy link
Contributor

sourcery-ai bot commented Jun 17, 2024

Reviewer's Guide by Sourcery

This pull request introduces a new method set_labels in the omnivoreql.py file to set labels for a page. The method accepts parameters for page ID, labels, label IDs, and source, and executes a GraphQL mutation to apply the labels. Corresponding unit tests have been added in tests/test_omnivoreql.py to verify the functionality of the new method.

File-Level Changes

Files Changes
omnivoreql/omnivoreql.py
tests/test_omnivoreql.py
Introduced a new method set_labels in omnivoreql.py to set labels for a page and added corresponding unit tests in tests/test_omnivoreql.py.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yazdipour - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 3 issues found
  • 🟢 Security: all looks good
  • 🟡 Testing: 3 issues found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

omnivoreql/omnivoreql.py Outdated Show resolved Hide resolved
omnivoreql/omnivoreql.py Outdated Show resolved Hide resolved
omnivoreql/omnivoreql.py Outdated Show resolved Hide resolved
tests/test_omnivoreql.py Show resolved Hide resolved
tests/test_omnivoreql.py Outdated Show resolved Hide resolved
tests/test_omnivoreql.py Outdated Show resolved Hide resolved
@yazdipour yazdipour merged commit a9a5cec into main Jun 18, 2024
3 checks passed
@yazdipour yazdipour deleted the feature/set_labels branch June 18, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant