Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shebang lines #9

Merged
merged 1 commit into from
Feb 7, 2018
Merged

Add shebang lines #9

merged 1 commit into from
Feb 7, 2018

Conversation

ohle
Copy link

@ohle ohle commented Feb 7, 2018

This fixes the string substitutions on systems where the default shell
is not bash

This fixes the string substitutions on systems where the default shell
is not bash
Copy link
Owner

@yazgoo yazgoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contrib.
Couldn't we support these shells instead - e.g. using backticks if that's required (and use /usr/bin/env sh) ?

@ohle
Copy link
Author

ohle commented Feb 7, 2018

The tricky part is the string indexing (${caller:1}). The only way I can think of doing this in POSIX sh would involve sed. I can do that if you think that's better than depending on bash. (I agree depending on bash is not ideal). Or do you have a better idea?

@yazgoo
Copy link
Owner

yazgoo commented Feb 7, 2018

Ok for me

@yazgoo yazgoo merged commit 50d3b9a into yazgoo:master Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants