[READY] Improve Clangd completer initialization #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1187 +/- ##
=========================================
+ Coverage 97.28% 97.38% +0.1%
=========================================
Files 95 95
Lines 7102 7529 +427
=========================================
+ Hits 6909 7332 +423
- Misses 193 197 +4 |
bstaletic
approved these changes
Feb 2, 2019
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @micbou)
ycmd/completers/cpp/clangd_completer.py, line 133 at r1 (raw file):
return None, None if not clangd:
Why not just else:?
This brings the following changes to the Clangd completer: - do not raise an exception when initializing the Clangd completer since this prevents ycmd from falling back to the libclang completer; - never fall back to the third-party Clangd if the one specified in 'clangd_binary_path' is not valid; - expand environment variables and '~' in the path specified by the 'clangd_binary_path' option; - do not print in the logs that the Clangd library is outdated if the path does not point to an executable; - cosmetic changes like capitalizing Clangd in comments.
micbou
force-pushed
the
clangd-init-no-exception
branch
from
1bbc404
to
044880c
Compare
micbou
commented
Feb 3, 2019
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: 0 of 2 LGTMs obtained (and 1 stale)
ycmd/completers/cpp/clangd_completer.py, line 133 at r1 (raw file):
Previously, bstaletic (Boris Staletic) wrote…
Why not just
else:?
Done.
bstaletic
approved these changes
Feb 3, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: 1 of 2 LGTMs obtained
|
Thanks for the PR! @zzbot r+ |
|
📌 Commit 044880c has been approved by |
zzbot
added a commit
that referenced
this pull request
Feb 11, 2019
[READY] Improve Clangd completer initialization This PR brings the following changes to the Clangd completer: - do not raise an exception when initializing the Clangd completer since this prevents ycmd from falling back to the libclang completer; - never fall back to the third-party Clangd if the one specified in `clangd_binary_path` is not valid. The reason behind that change is that I think most users are going to be confused by such fallback since they'll think that the Clangd from `clangd_binary_path` is used while in fact it's not. I can revert this change if you disagree; - expand environment variables and `~` in the path specified by the `clangd_binary_path` option; - do not print in the logs that the Clangd library is outdated if the path does not point to an executable; - cosmetic changes like capitalizing Clangd in comments and logs. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/1187) <!-- Reviewable:end -->
|
💔 Test failed - status-travis |
|
☀️ Test successful - status-appveyor, status-travis |
zzbot
added a commit
to ycm-core/YouCompleteMe
that referenced
this pull request
Mar 12, 2019
[READY] Update ycmd Include the following changes: - PR ycm-core/ycmd#1180: trigger semantic completion when instructed by server; - PR ycm-core/ycmd#1184: simplify LSP completer API for starting server; - PR ycm-core/ycmd#1187: improve Clangd completer initialization; - PR ycm-core/ycmd#1191: ease Clangd completer initialization; - PR ycm-core/ycmd#1193: fix system header search paths on macOS for Objective-C++; - PR ycm-core/ycmd#1194: update Jedi to 0.13.3 and Parso to 0.3.4; - PR ycm-core/ycmd#1195: ignore identifiers returned by TSServer in JavaScript; - PR ycm-core/ycmd#1196: update TSServer to 3.3.3333; - PR ycm-core/ycmd#1197: support -B flag in C-family languages. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/3339) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the following changes to the Clangd completer:
clangd_binary_pathis not valid. The reason behind that change is that I think most users are going to be confused by such fallback since they'll think that the Clangd fromclangd_binary_pathis used while in fact it's not. I can revert this change if you disagree;~in the path specified by theclangd_binary_pathoption;This change is