Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] Update TSServer to 3.3.3333 #1196

Merged
merged 1 commit into from Mar 6, 2019
Merged

Conversation

micbou
Copy link
Collaborator

@micbou micbou commented Feb 25, 2019

In addition to update TSServer (they must really like the number 3), this fixes one of the Javascript formatting test which wasn't formatting the right part of the file.


This change is Reviewable

Fix Javascript formatting test.
Copy link
Collaborator

@bstaletic bstaletic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: 1 of 2 LGTMs obtained

@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #1196 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1196   +/-   ##
=======================================
  Coverage   97.28%   97.28%           
=======================================
  Files          95       95           
  Lines        7109     7109           
=======================================
  Hits         6916     6916           
  Misses        193      193

Copy link
Member

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! 2 of 2 LGTMs obtained

@micbou
Copy link
Collaborator Author

micbou commented Mar 5, 2019

@zzbot r+

@zzbot
Copy link
Contributor

zzbot commented Mar 5, 2019

📌 Commit 702c9b6 has been approved by micbou

@zzbot
Copy link
Contributor

zzbot commented Mar 6, 2019

⌛ Testing commit 702c9b6 with merge cd94ea3...

zzbot added a commit that referenced this pull request Mar 6, 2019
[READY] Update TSServer to 3.3.3333

In addition to update TSServer (they must really like the number 3), this fixes one of the Javascript formatting test which wasn't formatting the right part of the file.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/1196)
<!-- Reviewable:end -->
@zzbot
Copy link
Contributor

zzbot commented Mar 6, 2019

☀️ Test successful - status-appveyor, status-travis
Approved by: micbou
Pushing cd94ea3 to master...

@zzbot zzbot merged commit 702c9b6 into ycm-core:master Mar 6, 2019
@micbou micbou deleted the update-tsserver branch March 6, 2019 10:46
zzbot added a commit to ycm-core/YouCompleteMe that referenced this pull request Mar 12, 2019
[READY] Update ycmd

Include the following changes:

 - PR ycm-core/ycmd#1180: trigger semantic completion when instructed by server;
 - PR ycm-core/ycmd#1184: simplify LSP completer API for starting server;
 - PR ycm-core/ycmd#1187: improve Clangd completer initialization;
 - PR ycm-core/ycmd#1191: ease Clangd completer initialization;
 - PR ycm-core/ycmd#1193: fix system header search paths on macOS for Objective-C++;
 - PR ycm-core/ycmd#1194: update Jedi to 0.13.3 and Parso to 0.3.4;
 - PR ycm-core/ycmd#1195: ignore identifiers returned by TSServer in JavaScript;
 - PR ycm-core/ycmd#1196: update TSServer to 3.3.3333;
 - PR ycm-core/ycmd#1197: support -B flag in C-family languages.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/3339)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants