[READY] Add -B to INCLUDE_FLAGS #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micbou
approved these changes
Mar 1, 2019
There was a problem hiding this comment.
Thanks for explaining what the flag does.
Reviewed 2 of 2 files at r1.
Reviewable status: 1 of 2 LGTMs obtained
Codecov Report
@@ Coverage Diff @@
## master #1197 +/- ##
=======================================
Coverage 97.28% 97.28%
=======================================
Files 95 95
Lines 7109 7109
=======================================
Hits 6916 6916
Misses 193 193 |
puremourning
approved these changes
Mar 5, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 2 of 2 LGTMs obtained
|
@zzbot r+ |
|
📌 Commit 7a83a14 has been approved by |
zzbot
added a commit
that referenced
this pull request
Mar 6, 2019
[READY] Add -B to INCLUDE_FLAGS This flag tells the compiler frontend (`gcc`/`clang`) where to look for the subprograms (`cpp`, `cc`, `cc1plus`, `as`, `ld` etc.). This flag is needed when bootstrapping a toolchain, so it is unlikely to be found in a custom extra conf, but it can appear in users' compilation databases. While it is not really an include flag, it behaves just like one. Fixes ycm-core/YouCompleteMe#3333 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/1197) <!-- Reviewable:end -->
|
💔 Test failed - status-travis |
|
@zzbot retry |
zzbot
added a commit
that referenced
this pull request
Mar 6, 2019
[READY] Add -B to INCLUDE_FLAGS This flag tells the compiler frontend (`gcc`/`clang`) where to look for the subprograms (`cpp`, `cc`, `cc1plus`, `as`, `ld` etc.). This flag is needed when bootstrapping a toolchain, so it is unlikely to be found in a custom extra conf, but it can appear in users' compilation databases. While it is not really an include flag, it behaves just like one. Fixes ycm-core/YouCompleteMe#3333 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/1197) <!-- Reviewable:end -->
|
💔 Test failed - status-travis |
|
☀️ Test successful - status-appveyor, status-travis |
zzbot
added a commit
to ycm-core/YouCompleteMe
that referenced
this pull request
Mar 12, 2019
[READY] Update ycmd Include the following changes: - PR ycm-core/ycmd#1180: trigger semantic completion when instructed by server; - PR ycm-core/ycmd#1184: simplify LSP completer API for starting server; - PR ycm-core/ycmd#1187: improve Clangd completer initialization; - PR ycm-core/ycmd#1191: ease Clangd completer initialization; - PR ycm-core/ycmd#1193: fix system header search paths on macOS for Objective-C++; - PR ycm-core/ycmd#1194: update Jedi to 0.13.3 and Parso to 0.3.4; - PR ycm-core/ycmd#1195: ignore identifiers returned by TSServer in JavaScript; - PR ycm-core/ycmd#1196: update TSServer to 3.3.3333; - PR ycm-core/ycmd#1197: support -B flag in C-family languages. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/3339) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag tells the compiler frontend (
gcc/clang) where to look for the subprograms (cpp,cc,cc1plus,as,ldetc.). This flag is needed when bootstrapping a toolchain, so it is unlikely to be found in a custom extra conf, but it can appear in users' compilation databases. While it is not really an include flag, it behaves just like one.Fixes ycm-core/YouCompleteMe#3333
This change is