Fix system header search paths on macOS for Objective-C++, too. #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Feb 22, 2019
…its own libclang." This reverts commit 75a861f. Reason for revert: It turns out this is an upstream issue. See: - https://chromium-review.googlesource.com/c/chromium/src/+/1482557 - ycm-core/ycmd#1193 Original change's description: > [Vim/YCM] Fix missing system headers when YCM was built with its own libclang. > > Bug: 932667 > Change-Id: I2eb9965da1eb3f9ad4a5ce103cf6e32d35019e48 > Reviewed-on: https://chromium-review.googlesource.com/c/1476105 > Auto-Submit: Sidney San Martín <sdy@chromium.org> > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Commit-Queue: Asanka Herath <asanka@chromium.org> > Reviewed-by: Asanka Herath <asanka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#632846} TBR=sdy@chromium.org,asanka@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 932667 Change-Id: I5a684c91723d28470e1d903cd74674ce145b421b Reviewed-on: https://chromium-review.googlesource.com/c/1483709 Reviewed-by: Sidney San Martín <sdy@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#634829}
This change just augments 4993964 to apply to `-x objective-c++` as well as `-x c++` files.
Codecov Report
@@ Coverage Diff @@
## master #1193 +/- ##
==========================================
- Coverage 97.28% 96.46% -0.82%
==========================================
Files 95 95
Lines 7108 7109 +1
==========================================
- Hits 6915 6858 -57
- Misses 193 251 +58 |
Codecov Report
@@ Coverage Diff @@
## master #1193 +/- ##
==========================================
+ Coverage 97.28% 97.28% +<.01%
==========================================
Files 95 95
Lines 7108 7109 +1
==========================================
+ Hits 6915 6916 +1
Misses 193 193 |
|
Hmm, I think the CI failure is unrelated to my change. |
micbou
approved these changes
Feb 23, 2019
There was a problem hiding this comment.
Thanks for the PR.
Hmm, I think the CI failure is unrelated to my change.
Yes, it was a flake.
Reviewed 2 of 2 files at r1.
Reviewable status: 1 of 2 LGTMs obtained
complete! 2 of 2 LGTMs obtained
|
@zzbot r+ |
|
📌 Commit 832ee83 has been approved by |
zzbot
added a commit
that referenced
this pull request
Feb 23, 2019
… r=micbou Fix system header search paths on macOS for Objective-C++, too. I've been running into ycm-core/YouCompleteMe#303, even though ycmd has a workaround for it. It looks like the issue is just that I'm writing ObjC++ and that change only affects C++. So, this change makes `-x objective-c++` eligible, too. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/1193) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-travis |
zzbot
added a commit
to ycm-core/YouCompleteMe
that referenced
this pull request
Mar 12, 2019
[READY] Update ycmd Include the following changes: - PR ycm-core/ycmd#1180: trigger semantic completion when instructed by server; - PR ycm-core/ycmd#1184: simplify LSP completer API for starting server; - PR ycm-core/ycmd#1187: improve Clangd completer initialization; - PR ycm-core/ycmd#1191: ease Clangd completer initialization; - PR ycm-core/ycmd#1193: fix system header search paths on macOS for Objective-C++; - PR ycm-core/ycmd#1194: update Jedi to 0.13.3 and Parso to 0.3.4; - PR ycm-core/ycmd#1195: ignore identifiers returned by TSServer in JavaScript; - PR ycm-core/ycmd#1196: update TSServer to 3.3.3333; - PR ycm-core/ycmd#1197: support -B flag in C-family languages. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/3339) <!-- Reviewable:end -->
SergioOpenPeer
pushed a commit
to webrtc-uwp/chromium-tools
that referenced
this pull request
May 10, 2019
…its own libclang." This reverts commit 75a861f213f0a3156743b68b5b3a060849abcfa4. Reason for revert: It turns out this is an upstream issue. See: - https://chromium-review.googlesource.com/c/chromium/src/+/1482557 - ycm-core/ycmd#1193 Original change's description: > [Vim/YCM] Fix missing system headers when YCM was built with its own libclang. > > Bug: 932667 > Change-Id: I2eb9965da1eb3f9ad4a5ce103cf6e32d35019e48 > Reviewed-on: https://chromium-review.googlesource.com/c/1476105 > Auto-Submit: Sidney San Martín <sdy@chromium.org> > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Commit-Queue: Asanka Herath <asanka@chromium.org> > Reviewed-by: Asanka Herath <asanka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#632846} TBR=sdy@chromium.org,asanka@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 932667 Change-Id: I5a684c91723d28470e1d903cd74674ce145b421b Reviewed-on: https://chromium-review.googlesource.com/c/1483709 Reviewed-by: Sidney San Martín <sdy@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#634829} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: a3e4d14604cf4403caed57da074a863910643141
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been running into ycm-core/YouCompleteMe#303, even though ycmd has a workaround for it. It looks like the issue is just that I'm writing ObjC++ and that change only affects C++.
So, this change makes
-x objective-c++eligible, too.This change is