[READY] Add diag kind to /detailed_diagnostic response #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstaletic
force-pushed
the
detailed-diag-with-kindness
branch
from
eb72dcc
to
90f85b5
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1720 +/- ##
=======================================
Coverage 95.42% 95.42%
=======================================
Files 83 83
Lines 8127 8132 +5
Branches 164 164
=======================================
+ Hits 7755 7760 +5
Misses 322 322
Partials 50 50 |
bstaletic
force-pushed
the
detailed-diag-with-kindness
branch
2 times, most recently
from
63a9aaa
to
c953a8f
Compare
puremourning
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @bstaletic)
|
Thanks for sending a PR! |
4 tasks
puremourning
added a commit
to dkaszews/YouCompleteMe
that referenced
this pull request
Dec 28, 2023
puremourning
added a commit
to dkaszews/YouCompleteMe
that referenced
this pull request
Dec 28, 2023
Broken by ycm-core/ycmd#1720 - Add diagnostic type to output Inexplicable syntax errors Missing semantic_highlighting groups lead to unexpected output Improve diagnostic test failure messages - print the popup positions
puremourning
added a commit
to dkaszews/YouCompleteMe
that referenced
this pull request
Dec 28, 2023
Broken by ycm-core/ycmd#1720 - Add diagnostic type to output Inexplicable syntax errors Missing semantic_highlighting groups lead to unexpected output Improve diagnostic test failure messages - print the popup positions
puremourning
added a commit
to dkaszews/YouCompleteMe
that referenced
this pull request
Dec 28, 2023
Broken by ycm-core/ycmd#1720 - Add diagnostic type to output Inexplicable syntax errors Missing semantic_highlighting groups lead to unexpected output Improve diagnostic test failure messages - print the popup positions
puremourning
added a commit
to dkaszews/YouCompleteMe
that referenced
this pull request
Dec 28, 2023
Broken by ycm-core/ycmd#1720 - Add diagnostic type to output Inexplicable syntax errors Missing semantic_highlighting groups lead to unexpected output Improve diagnostic test failure messages - print the popup positions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like I mentioned in gitter, we are missing
kindin the/detailed_diagnosticresponse.I am being lazy, so letting CI tell me if any tests are broken.
This change is