Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[READY] Rewrite FindPythonLibraries function in build script #499

Merged
merged 1 commit into from
May 24, 2016
Merged

[READY] Rewrite FindPythonLibraries function in build script #499

merged 1 commit into from
May 24, 2016

Conversation

micbou
Copy link
Collaborator

@micbou micbou commented May 18, 2016 •
edited
Loading

This should take care of:

  • system Python (with or without the m suffix in the library name for Python 3) on Linux, OS X, and Windows;
  • pyenv Python on Linux and OS X (no pyenv on Windows);
  • virtual environments (virtualenv and pyvenv) on Linux, OS X, and Windows.

Fixes #494.
Fixes #500.
Fixes #502.
Fixes ycm-core/YouCompleteMe#2162.
Fixes ycm-core/YouCompleteMe#2175.

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.957% when pulling 71af9fe on micbou:find-python-libs-improved into 18fc8d8 on Valloric:master.

@Valloric
Copy link
Member

Looks great! Thanks for the PR!

:lgtm:

Previously, coveralls wrote…

Coverage Status

Coverage remained the same at 84.957% when pulling 71af9fe on micbou:find-python-libs-improved into 18fc8d8 on Valloric:master.

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

build.py, line 185 [r1] (raw file):

  #  - if a static library is found instead, raise an error with instructions
  #    on how to build Python as a dynamic library.
  #  - if no libraries are found, raise a generic error.

Fantastic docs here, thanks!

Comments from Reviewable

This was referenced May 19, 2016
Merged
Closed
@micbou micbou changed the title [READY] Rewrite FindPythonLibraries function in build script [WIP] Rewrite FindPythonLibraries function in build script May 19, 2016
@vheon vheon mentioned this pull request May 19, 2016
Closed
@micbou micbou force-pushed the find-python-libs-improved branch from 71af9fe to e59b442 Compare May 19, 2016 23:58
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.957% when pulling e59b442 on micbou:find-python-libs-improved into 18fc8d8 on Valloric:master.

@micbou micbou force-pushed the find-python-libs-improved branch from e59b442 to f21929f Compare May 20, 2016 14:24
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.957% when pulling f21929f on micbou:find-python-libs-improved into 18fc8d8 on Valloric:master.

@micbou
Rewrite FindPythonLibraries in build script
8b6ea5e 
Merge the FindPythonLibraries functions specific to each platform
into one function.
Use get_python_inc function from sysconfig module on all platforms to
find the Python headers.
Using ldconfig to find the Python libraries is not reliable. Instead,
we search them through the library directory and its subdirectories.
Use regular expressions to find static and dynamic Python libraries.
@micbou micbou force-pushed the find-python-libs-improved branch from f21929f to 8b6ea5e Compare May 20, 2016 15:23
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.957% when pulling 8b6ea5e on micbou:find-python-libs-improved into 18fc8d8 on Valloric:master.

@micbou micbou changed the title [WIP] Rewrite FindPythonLibraries function in build script [READY] Rewrite FindPythonLibraries function in build script May 21, 2016
@micbou
Copy link
Collaborator Author

micbou commented May 21, 2016

Updated to fix issues #500, #502, and ycm-core/YouCompleteMe#2175.

Previously, coveralls wrote…

Coverage Status

Coverage remained the same at 84.957% when pulling 8b6ea5e on micbou:find-python-libs-improved into 18fc8d8 on Valloric:master.

Reviewed 1 of 1 files at r1, 1 of 1 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@Valloric
Copy link
Member

Still :lgtm:.

Holy hell, Python is a goddamn never-ending stream of problems.

Previously, micbou wrote…

Updated to fix issues #500, #502, and ycm-core/YouCompleteMe#2175.

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@ff2000
Copy link

ff2000 commented May 23, 2016

Also fixes the errors for me. Thx!

@micbou
Copy link
Collaborator Author

micbou commented May 23, 2016

Great. I think this is definitely ready.

@puremourning @vheon Care to review?

Previously, ff2000 wrote…

Also fixes the errors for me. Thx!

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

This was referenced May 24, 2016
Closed
Closed
@vheon
Copy link
Contributor

vheon commented May 24, 2016

:lgtm: @homu r=Valloric

Previously, micbou wrote…

Great. I think this is definitely ready.

@puremourning @vheon Care to review?

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@homu
Copy link
Contributor

homu commented May 24, 2016

📌 Commit 8b6ea5e has been approved by Valloric

@homu
Copy link
Contributor

homu commented May 24, 2016

⌛ Testing commit 8b6ea5e with merge 22f229c...

homu added a commit that referenced this pull request May 24, 2016
@homu
Auto merge of #499 - micbou:find-python-libs-improved, r=Valloric
22f229c 
[READY] Rewrite FindPythonLibraries function in build script

This should take care of:
 - system Python (with or without the `m` suffix in the library name for Python 3) on Linux, OS X, and Windows;
 - `pyenv` Python on Linux and OS X (no `pyenv` on Windows);
 - virtual environments (`virtualenv` and `pyvenv`) on Linux, OS X, and Windows.

Fixes #494.
Fixes #500.
Fixes #502.
Fixes ycm-core/YouCompleteMe#2162.
Fixes ycm-core/YouCompleteMe#2175.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/499)
<!-- Reviewable:end -->
@homu
Copy link
Contributor

homu commented May 24, 2016

☀️ Test successful - status

@homu homu merged commit 8b6ea5e into ycm-core:master May 24, 2016
@Valloric Valloric mentioned this pull request May 25, 2016
Merged
homu added a commit to ycm-core/YouCompleteMe that referenced this pull request May 25, 2016
@homu
Auto merge of #2183 - Valloric:update, r=micbou
8b1fba2 
[READY] Updating to latest ycmd

We want to merge this soon to get @micbou's wonderful ycm-core/ycmd#499 PR out.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2183)
<!-- Reviewable:end -->
@micbou micbou deleted the find-python-libs-improved branch May 25, 2016 20:47
@micbou micbou mentioned this pull request Aug 4, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@micbou @coveralls @Valloric @ff2000 @vheon @homu