build: fix python_finder: prefer python2, look for/prefer .so
#55
Conversation
|
Travis is not happy |
|
That's a flake8 error for the testdata files. It seems to be unrelated to this PR, isn't it? |
| # So we are forced to do its job for it. | ||
| python_prefix=$(python-config --prefix | sed 's/^[ \t]*//') | ||
| # Prefer python2-config over python-config. | ||
| hash python2-config 2>/dev/null && python_config=python2-config \ |
There was a problem hiding this comment.
It seems you want to use command_exists, which is declared in this file.
blueyed
force-pushed
the
fix-build-python-config
branch
3 times, most recently
from
b41a5af
to
0caf357
Compare
|
You need to state did you sign the Google CLA. |
|
Also, why should we prefer the .so version of the .a? |
This fixes building YCM / ycmd for pyenv with python3 and python2 activated/configured.
I had a `.rej` file from `patch` for a submodule, and check_third_party_libs complained about it.
blueyed
force-pushed
the
fix-build-python-config
branch
from
0caf357
to
cbcef3a
Compare
I am not sure and remember it not completely anymore. It is probably related to first installing python without
No. |
You can't push anything to the repo if you do not sign the Google CLA. |
Then please don't send pull requests! |
This fixes building YCM / ycmd for pyenv with python3 and python2
activated/configured.