fix(TableInfo): update column table info #1056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
885-column-table-info
branch
from
4b8a113 to
68e8862
Compare
artemmufazalov
commented
Jul 23, 2024
Comment on lines
51
to
62
| if (columnTable.Sharding?.HashSharding?.Columns) { | ||
| const columns = columnTable.Sharding.HashSharding.Columns.join(', '); | ||
| const content = `PARTITION BY HASH(${columns})`; | ||
|
|
||
| columnTableGeneralInfo.push({ | ||
| label: 'Partitioning', | ||
| value: ( | ||
| <Text variant="code-2" wordBreak="break-word"> | ||
| {content} | ||
| </Text> | ||
| ), | ||
| }); |
artemmufazalov
commented
Jul 23, 2024
Comment on lines
+219
to
+224
| 'GroupReadIops', | ||
| 'GroupReadThroughput', | ||
| 'GroupWriteIops', | ||
| 'GroupWriteThroughput', |
There was a problem hiding this comment.
Removed fields, that we don't display, but they are not processed properly by TS
artemmufazalov
commented
Jul 23, 2024
Comment on lines
+138
to
142
| export const formatDateTime = (value?: number | string, defaultValue = '') => { | ||
| const formattedData = dateTimeParse(Number(value))?.format('YYYY-MM-DD HH:mm'); | ||
|
|
||
| return Number(value) > 0 && formattedData ? formattedData : defaultValue; | ||
| return formattedData ?? defaultValue; | ||
| }; |
There was a problem hiding this comment.
Do not display N/A for undefined fields by default. In case below we just don't display date fields:
artemmufazalov
force-pushed
the
885-column-table-info
branch
from
68e8862 to
a881797
Compare
artemmufazalov
commented
Jul 23, 2024
Comment on lines
+167
to
+180
| if (PathDescription?.TableStats) { | ||
| const {DataSize, RowCount} = PathDescription.TableStats; | ||
|
|
||
| overview.push( | ||
| { | ||
| label: i18n('summary.data-size'), | ||
| value: toFormattedSize(DataSize), | ||
| }, | ||
| { | ||
| label: i18n('summary.row-count'), | ||
| value: formatNumber(RowCount), | ||
| }, | ||
| ); | ||
| } |
There was a problem hiding this comment.
Add Data size and Row count fields for entities, which have these params
artemmufazalov
force-pushed
the
885-column-table-info
branch
from
a881797 to
8366717
Compare
Raubzeug
previously approved these changes
Jul 24, 2024
| const content = `PARTITION BY HASH(${columns})`; | ||
|
|
||
| columnTableGeneralInfo.push({ | ||
| label: 'Partitioning', |
artemmufazalov
force-pushed
the
885-column-table-info
branch
from
8366717 to
78d8953
Compare
Raubzeug
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of #885 (there are some things about column tables to clarify and finish)