Skip to content

feat: use features versions from backend #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Conversation

artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Jul 31, 2024

Closes: #1077

To illustrate new handler, replaced two settings with feature versions from backend

Stand: https://nda.ya.ru/t/B1vOjA4N77KBQK

@artemmufazalov artemmufazalov marked this pull request as ready for review July 31, 2024 16:12

export const capabilitiesApi = api.injectEndpoints({
endpoints: (build) => ({
getClusterCapabilitie: build.query({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo getClusterCapabilities

try {
const data = await window.api.getClusterCapabilities();
const {Capabilities} = data;
return {data: Capabilities};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we don't need any checks here, we may just return {data}

@artemmufazalov artemmufazalov changed the title feat: use features versions from backend use features versions from backend Aug 1, 2024
@artemmufazalov artemmufazalov changed the title use features versions from backend feat: use features versions from backend Aug 1, 2024
@artemmufazalov artemmufazalov requested a review from Raubzeug August 1, 2024 10:11
@artemmufazalov artemmufazalov merged commit 3f041de into main Aug 1, 2024
6 of 7 checks passed
@artemmufazalov artemmufazalov deleted the 1077-capabilities branch August 1, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch available features info/versions from server
2 participants