Skip to content

fix: operations tab #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jun 24, 2025
Merged

fix: operations tab #2435

merged 18 commits into from
Jun 24, 2025

Conversation

astandrik
Copy link
Collaborator

@astandrik astandrik commented Jun 19, 2025 •
edited by github-actions bot
Loading

Closes #1821
Stand

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
342 336 0 1 5
Test Changes Summary ✨3 ⏭️3

✨ New Tests (3)

  1. loads initial page of operations on tab click (tenant/diagnostics/tabs/operations.test.ts)
  2. loads more operations on scroll (tenant/diagnostics/tabs/operations.test.ts)
  3. shows empty state when no operations (tenant/diagnostics/tabs/operations.test.ts)

⏭️ Skipped Tests (3)

  1. Query tab first row has values for all columns in Top mode (tenant/diagnostics/tabs/queries.test.ts)
  2. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  3. TopShards tab first row has values for all columns in History mode (tenant/diagnostics/tabs/topShards.test.ts)

Bundle Size: 🔺

Current: 83.99 MB | Main: 83.89 MB
Diff: +0.10 MB (0.12%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@Raubzeug
Copy link
Contributor

Something very strange is happening if scroll to bottom the first time very quick screencast

@astandrik
Copy link
Collaborator Author

bugbot run

cursor[bot]

This comment was marked as outdated.

Sign in to view

@astandrik astandrik requested a review from Copilot June 22, 2025 10:37
Copilot

This comment was marked as outdated.

Sign in to view

@astandrik astandrik requested a review from Copilot June 24, 2025 09:18
@astandrik
Copy link
Collaborator Author

bugbot run

Copilot

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

@astandrik
Copy link
Collaborator Author

bugbot run

@astandrik astandrik requested a review from Copilot June 24, 2025 11:18
Copilot

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

@astandrik astandrik requested a review from Copilot June 24, 2025 11:27
Copilot

This comment was marked as outdated.

Sign in to view

@astandrik
Copy link
Collaborator Author

@Raubzeug moved to infiniteQuery, added tests, skipped broken tests (with TODO)

Raubzeug
Raubzeug requested changes Jun 24, 2025
View reviewed changes
src/containers/Operations/useOperationsInfiniteQuery.ts Outdated
}, [checkAndLoadMorePages]);

// Listen for diagnostics refresh events
React.useEffect(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets use rtk Tags for this case.

src/containers/Tenant/Diagnostics/Diagnostics.tsx Outdated
<AutoRefreshControl />
<AutoRefreshControl
onManualRefresh={() => {
const event = new CustomEvent('diagnosticsRefresh');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need if we use Tag.

src/store/reducers/operations.ts Outdated
string | undefined // Page param type (page token)
>({
infiniteQueryOptions: {
initialPageParam: undefined as string | undefined,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we get rid of type cast?

@astandrik
Copy link
Collaborator Author

@Raubzeug review fixed, stand redeployed

@astandrik astandrik requested a review from Raubzeug June 24, 2025 14:58
@astandrik astandrik added this pull request to the merge queue Jun 24, 2025
Merged via the queue into main with commit 937c561 Jun 24, 2025
7 checks passed
@astandrik astandrik deleted the astandrik.1821 branch June 24, 2025 15:44
@ydb-platform-bot ydb-platform-bot mentioned this pull request Jun 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@cursor cursor[bot] cursor[bot] left review comments

@Raubzeug Raubzeug Raubzeug approved these changes

@artemmufazalov artemmufazalov Awaiting requested review from artemmufazalov artemmufazalov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix operations tab
2 participants
@astandrik @Raubzeug