Skip to content

Conversation

Raubzeug
Copy link
Contributor

@Raubzeug Raubzeug commented Sep 16, 2025

closes #2886

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
378 373 0 3 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 85.45 MB | Main: 85.45 MB
Diff: +2.92 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@@ -34,7 +34,9 @@ export function Tablets({
const [autoRefreshInterval] = useAutoRefreshInterval();

let params: TabletsApiRequestParams = {};
const filter = onlyActive ? `(State!=Dead)` : undefined;
const filter = onlyActive
? `(State=[Created,ResolveStateStorage,Candidate,BlockBlobStorage,RebuildGraph,WriteZeroEntry,Restored,Discover,Lock,Active,ResolveLeader,Terminating])`
Copy link
Member

@artemmufazalov artemmufazalov Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Number of not active statuses is much less than active. Is it possible to set filter as State!=[Dead,Deleted,Stopped]? Found the answer in the ticket

Also it will be good to ensure proper strings with types:

const activeStatuses: ETabletState = [
    'Created',
    'ResolveStateStorage',
    'Candidate',
    'BlockBlobStorage',
    'RebuildGraph',
    'WriteZeroEntry',
    'Restored',
    'Discover',
    'Lock',
    'Active',
    'ResolveLeader',
    'Terminating'
]

const filter = onlyActive ? `(State=${activeStatuses.join(',')}` : undefined

artemmufazalov
artemmufazalov previously approved these changes Sep 16, 2025
@Raubzeug Raubzeug added this pull request to the merge queue Sep 16, 2025
Merged via the queue into main with commit 5d832fd Sep 16, 2025
5 checks passed
@Raubzeug Raubzeug deleted the tablets-filter branch September 16, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change tablets filter on node page
2 participants