feat: remove additionalNodesProps #2941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the additionalNodesProps pattern from the codebase to simplify developer UI links functionality. The change eliminates the abstraction layer for handling node references and instead uses the new useNodeDeveloperUIHref hook directly in components that need developer UI links.
Key changes:
- Removed
AdditionalNodesPropstype and related functions - Replaced
useAdditionalNodesPropshook with direct usage ofuseNodeDeveloperUIHref - Updated all components to no longer pass or use
additionalNodesProps
Reviewed Changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/utils/hooks/useNodeDeveloperUIHref.ts |
Updated to handle node developer UI logic directly instead of using additional props |
src/utils/hooks/useAdditionalNodesProps.ts |
Completely removed - no longer needed |
src/utils/additionalProps.ts |
Removed getAdditionalNodesProps function and related types |
src/types/additionalProps.ts |
Removed AdditionalNodesProps and GetNodeRefFunc type definitions |
| Multiple component files | Removed additionalNodesProps parameters and usage throughout the component hierarchy |
src/components/NodeHostWrapper/NodeHostWrapper.tsx |
Simplified to use useNodeDeveloperUIHref hook directly |
src/components/TooltipsContent/NodeEndpointsTooltipContent/NodeEndpointsTooltipContent.tsx |
Updated to use the hook instead of passed props |
artemmufazalov
commented
Sep 30, 2025
| } | ||
|
|
||
| if (isUserAllowedToMakeChanges && nodeHref) { | ||
| if (developerUIInternalHref) { |
There was a problem hiding this comment.
We now check isUserAllowedToMakeChanges inside useNodeDeveloperUIHref
artemmufazalov
force-pushed
the
remove-additional-nodes-props
branch
from
8a0d265 to
0be0a7e
Compare
artemmufazalov
requested review from
Raubzeug,
adameat and
astandrik
as code owners
Raubzeug
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's needed to simplify work for developer ui links fix (#2919)
Part of #2137
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: 🔽
Current: 85.60 MB | Main: 85.61 MB
Diff: 8.85 KB (-0.01%)
✅ Bundle size decreased.
ℹ️ CI Information