Skip to content

Conversation

artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Oct 1, 2025

Closes #2930

Stand (you need to turn on columns VDisks with PDisks): https://nda.ya.ru/t/kyq51ofu7Kj7fX

The problem was in different timeouts for delayOpen (100) and delayClose (200) in PDisk component, so the order of functions calls was wrong

  1. onShowPopup={() => setHighlightedVDisk(vDiskId)}
  2. onHidePopup={() => setHighlightedVDisk(undefined)}

So highlighted VDisk ID always was undefined after mouse entered another PDisk.

Introduced single constant for all disks popup in storage to fix this issue.

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
378 375 0 1 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 85.59 MB | Main: 85.59 MB
Diff: +1.23 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@artemmufazalov artemmufazalov force-pushed the 2930-storage-groups-popups branch from 4de6464 to 380ea91 Compare October 1, 2025 10:43
@artemmufazalov artemmufazalov requested a review from Copilot October 1, 2025 10:44
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with VDisk popup hiding by standardizing the popup delay behavior across all disk-related components. The fix introduces a consistent debounce timeout for popup open/close operations to prevent unwanted popup flickering or premature hiding.

  • Introduces a shared constant DISKS_POPUP_DEBOUNCE_TIMEOUT for consistent popup timing
  • Updates all disk components to use the standardized delay values instead of hardcoded numbers
  • Adds delay configuration props to the PDisk component interface

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/containers/Storage/shared.tsx Adds shared constant for popup debounce timeout (200ms)
src/containers/Storage/VDisks/VDisks.tsx Applies consistent delay timing to VDisk popup components
src/containers/Storage/PDisk/PDisk.tsx Adds delay props to interface and uses shared constant instead of hardcoded values
src/containers/Storage/Disks/Disks.tsx Updates both VDisk and PDisk items to use consistent delay timing

@artemmufazalov artemmufazalov marked this pull request as ready for review October 1, 2025 10:54
@artemmufazalov artemmufazalov added this pull request to the merge queue Oct 2, 2025
Merged via the queue into main with commit 3b77a60 Oct 2, 2025
10 checks passed
@artemmufazalov artemmufazalov deleted the 2930-storage-groups-popups branch October 2, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StorageGroups: VDisk popup is not always shown
2 participants