Skip to content

fix(NewSQL): use the same icons as in schema tree #2948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2025
Merged

fix(NewSQL): use the same icons as in schema tree #2948

merged 1 commit into from
Oct 1, 2025

Conversation

artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Oct 1, 2025 •
edited by github-actions bot
Loading

Closes #2906

Stand: https://nda.ya.ru/t/DYHxkQAC7Kj24Y

Screenshot 2025-10-01 at 12 03 41

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
378 374 0 2 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 85.59 MB | Main: 85.59 MB
Diff: 3.00 KB (-0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@artemmufazalov artemmufazalov marked this pull request as ready for review October 1, 2025 10:10
@artemmufazalov artemmufazalov added this pull request to the merge queue Oct 1, 2025
Merged via the queue into main with commit b960d4d Oct 1, 2025
8 checks passed
@artemmufazalov artemmufazalov deleted the new-sql-icons branch October 1, 2025 10:42
@ydb-platform-bot ydb-platform-bot mentioned this pull request Oct 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astandrik astandrik astandrik approved these changes

@Raubzeug Raubzeug Raubzeug approved these changes

@adameat adameat Awaiting requested review from adameat adameat is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

сheck why replication has two types of icons and unify them
3 participants
@artemmufazalov @astandrik @Raubzeug