fix: fix developer ui links in cloud and em #2949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
commented
Oct 1, 2025
| const pDiskPath = createPDiskDeveloperUILink({ | ||
| nodeId, | ||
| pDiskId, | ||
| host: this.getPath(''), |
There was a problem hiding this comment.
This is default value in createDeveloperUILinkWithNodeId, that is used in createPDiskDeveloperUILink
There was a problem hiding this comment.
Pull Request Overview
This PR fixes developer UI links for clusters running in cloud and embedded modes by properly handling the use_meta_proxy configuration setting. When meta proxy is enabled, the system should use the current host instead of the balancer URL for generating developer UI links.
Key changes:
- Modified developer UI link generation to use current host when meta proxy is enabled
- Updated link generators to use a centralized
getCurrentHost()function instead of hardcoded backend - Added proper handling of the
useMetaProxyparameter in link generation functions
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/prepareBackend.ts | Added useMetaProxy parameter and logic to use current host when meta proxy is enabled |
| src/utils/hooks/useNodeDeveloperUIHref.ts | Updated to pass useMetaProxy setting to backend preparation function |
| src/utils/developerUI/developerUI.ts | Replaced hardcoded backend with getCurrentHost() function and removed host parameters |
| src/utils/developerUI/test/developerUI.test.ts | Added test setup to mock the window.api for getCurrentHost() function |
| src/services/api/pdisk.ts | Removed redundant host parameter since getCurrentHost() is now used by default |
artemmufazalov
requested review from
astandrik,
Raubzeug and
adameat
as code owners
Raubzeug
approved these changes
Oct 1, 2025
Raubzeug
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2919
Cluster with
use_meta_proxy=true: https://nda.ya.ru/t/_nh5uj-z7KjCKUCluster with
use_meta_proxy=false: https://nda.ya.ru/t/QBZ2jrfT7KjCPqWe have developer UI links for cluster, nodes, VDisks, PDisks, tablets
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: ✅
Current: 85.59 MB | Main: 85.59 MB
Diff: +0.57 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information