fix: show 5 digits size in table info #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
format-bytes
branch
2 times, most recently
from
d97fcd0 to
8c0b073
Compare
artemmufazalov
force-pushed
the
format-bytes
branch
from
8c0b073 to
4a38dc4
Compare
Raubzeug
requested changes
Jul 6, 2023
| let result = (Number(value) / sizes[size].value).toFixed(precision); | ||
| result = formatNumber(result); | ||
|
|
||
| if (withLabel) { |
There was a problem hiding this comment.
Lets move this case and case with isSpeed to another functions. Now it's pretty unclear what for this function is responsible.
There was a problem hiding this comment.
Do you suggest separating conditions? Or there shouldn't be logic with adding label in such function?
There was a problem hiding this comment.
I see it as two additional functions: one will give simple label, one will give /s label.
function withSpeed(val) {
return withLabel(val)
}
function withLabel(val) {
return formatBytes(val)
}
| @@ -0,0 +1,31 @@ | |||
| import {formatBytes} from '../formatBytes'; | |||
|
|
|||
| describe('formatBytes', () => { | |||
There was a problem hiding this comment.
Lets add test-cases with invalid data.
artemmufazalov
force-pushed
the
format-bytes
branch
2 times, most recently
from
51ef43c to
bd822de
Compare
Raubzeug
reviewed
Jul 7, 2023
artemmufazalov
force-pushed
the
format-bytes
branch
from
bd822de to
6377b21
Compare
Raubzeug
approved these changes
Jul 7, 2023
This was referenced Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.