Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: SLO workload action every PR #568

Closed
Tracked by #20
asmyasnikov opened this issue Feb 10, 2023 · 1 comment
Closed
Tracked by #20

dev: SLO workload action every PR #568

asmyasnikov opened this issue Feb 10, 2023 · 1 comment
Assignees
Labels

Comments

@asmyasnikov
Copy link
Member

Make as nodejs SDK https://github.com/ydb-platform/slo-nodejs/blob/main/.github/workflows/ci.yml

@asmyasnikov asmyasnikov added enhancement New feature or request student-projects labels Feb 10, 2023
@asmyasnikov asmyasnikov self-assigned this Feb 10, 2023
asmyasnikov pushed a commit that referenced this issue Feb 15, 2023
@zeruk
Copy link

zeruk commented Mar 3, 2023

@asmyasnikov Correct CI example now is here: https://github.com/ydb-platform/ydb-nodejs-sdk/blob/main/.github/workflows/slo.yml
Workload sample and description is here: https://github.com/ydb-platform/ydb-nodejs-sdk/tree/main/slo-workload
As you can see from the repository, you will need to create a directory for the workload package and provide a Dockerfile inside it.

Important note: Do not run SLO tests in pull requests. You will either have to open secrets for pull requests, or give rights to each contributor (which is not a safe method either). The way I see it, the best option is to run tests on the main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants