Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow arithmetic operations and operator* for const iterators #1663

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

4JustMe4
Copy link
Collaborator

@4JustMe4 4JustMe4 commented Feb 7, 2024

Changelog entry

Avoid

$(SOURCE_ROOT)/contrib/libs/cxxsupp/libcxx/include/__algorithm/sort.h:289:52: error: invalid operands to binary expression ('const NKikimr::NMiniKQL::(anonymous namespace)::TGatherIterator' and 'difference_type' (aka 'long'))
  const _RandomAccessIterator __leftmost = __first - difference_type(1); (void)__leftmost; // can be unused when assertions are disabled

Changelog category

  • Not for changelog (changelog entry is not required)

@4JustMe4 4JustMe4 requested a review from a team as a code owner February 7, 2024 11:20
Copy link

github-actions bot commented Feb 7, 2024

2024-02-07 11:50:23 UTC Pre-commit check for c2e3cf9 has started.
2024-02-07 11:50:25 UTC Build linux-x86_64-release-asan is running...
🔴 2024-02-07 11:51:49 UTC Build failed. see the build logs.
2024-02-07 11:51:59 UTC Tests are running...
🔴 2024-02-07 11:56:42 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3911 3600 0 294 4 13

Copy link

github-actions bot commented Feb 7, 2024

2024-02-07 11:51:55 UTC Pre-commit check for c2e3cf9 has started.
2024-02-07 11:51:56 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-02-07 11:53:51 UTC Build failed. see the build logs.
2024-02-07 11:54:02 UTC Tests are running...
🔴 2024-02-07 11:59:08 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
4041 3675 0 353 2 11

@4JustMe4
Copy link
Collaborator Author

4JustMe4 commented Feb 7, 2024

Тут тесты проходят.

Copy link

github-actions bot commented Feb 9, 2024

2024-02-09 12:15:09 UTC Pre-commit check for 2203dc0 has started.
2024-02-09 12:15:11 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-09 12:17:47 UTC Build successful.
2024-02-09 12:17:59 UTC Tests are running...
🔴 2024-02-09 13:57:23 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14739 14556 0 11 134 38

Copy link

github-actions bot commented Feb 9, 2024

2024-02-09 12:15:23 UTC Pre-commit check for 2203dc0 has started.
2024-02-09 12:15:25 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-09 12:18:36 UTC Build successful.
2024-02-09 12:18:48 UTC Tests are running...
🔴 2024-02-09 14:04:24 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67413 56488 0 1 10892 32

@alexv-smirnov alexv-smirnov merged commit 0eaa5f7 into ydb-platform:main Feb 9, 2024
2 of 4 checks passed
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
@serbel324 serbel324 mentioned this pull request Feb 13, 2024
@vitstn vitstn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants