Fix race condition between callback and destructor in TS3ExternalStorage #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thank you for contributing! |
ivanmorozov333
approved these changes
Feb 8, 2024
Merged
Closed
Merged
Merged
This was referenced Feb 17, 2024
azevaykin
pushed a commit
to azevaykin/ydb
that referenced
this pull request
May 2, 2024
azevaykin
pushed a commit
to azevaykin/ydb
that referenced
this pull request
May 2, 2024
azevaykin
added a commit
that referenced
this pull request
May 2, 2024
azevaykin
added a commit
that referenced
this pull request
May 2, 2024
Closed
This was referenced Jun 7, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog entry
Access the conditional variable
RunningQueriesNotifierin the callback under the mutex to prevent a race condition between this access and the TS3ExternalStorage destruction.Changelog category
Additional information
The race is reproducible with
./ya make -ttt ydb/core/tx/schemeshard/ut_export -F=TExportToS3Tests::CorruptedDyNumber --sanitize=thread