Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support cast in default values #1754

Merged
merged 1 commit into from
Feb 9, 2024
Merged

support cast in default values #1754

merged 1 commit into from
Feb 9, 2024

Conversation

gridnevvvit
Copy link
Member

Changelog entry

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024 •
edited
Loading

⚪ 2024-02-08 22:19:33 UTC Pre-commit check for 3ed7ded has started.
⚪ 2024-02-08 22:19:35 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-08 22:23:44 UTC Build successful.
⚪ 2024-02-08 22:23:51 UTC Tests are running...
🔴 2024-02-08 23:35:21 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67306 56370 0 4 10896 36

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024 •
edited
Loading

⚪ 2024-02-08 22:21:33 UTC Pre-commit check for 3ed7ded has started.
⚪ 2024-02-08 22:21:35 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-08 22:25:02 UTC Build successful.
⚪ 2024-02-08 22:25:16 UTC Tests are running...
🔴 2024-02-09 00:04:21 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14733 14538 0 20 134 41

@gridnevvvit gridnevvvit force-pushed the support-casts-in-default-values branch from 37bd9db to e98d381 Compare February 9, 2024 09:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024 •
edited
Loading

⚪ 2024-02-09 09:17:52 UTC Pre-commit check for ef0cd94 has started.
⚪ 2024-02-09 09:17:54 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-09 09:19:49 UTC Build successful.
⚪ 2024-02-09 09:20:02 UTC Tests are running...
🔴 2024-02-09 10:33:55 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67405 56462 0 1 10892 50

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024 •
edited
Loading

⚪ 2024-02-09 09:18:14 UTC Pre-commit check for ef0cd94 has started.
⚪ 2024-02-09 09:18:17 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-09 09:20:12 UTC Build successful.
⚪ 2024-02-09 09:20:25 UTC Tests are running...
🔴 2024-02-09 10:53:31 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14731 14532 0 14 144 41

qrort
qrort reviewed Feb 9, 2024
View reviewed changes
ydb/core/kqp/provider/yql_kikimr_type_ann.cpp
const auto& constrValue = constraint.Value().Cast();
bool isPgNull = constrValue.Ptr()->IsCallable() &&
constrValue.Ptr()->Content() == "PgCast" && constrValue.Ptr()->ChildrenSize() >= 1 &&
constrValue.Ptr()->Child(0)->IsCallable() && constrValue.Ptr()->Child(0)->Content() == "Null";
Copy link
Collaborator

@qrort qrort Feb 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Думаю, тут нужен case insensitive match по "Null". И круто быэто в отдельную функцию вытащить

spuchin
spuchin reviewed Feb 9, 2024
View reviewed changes
ydb/core/kqp/provider/yql_kikimr_datasink.cpp
continue;

YQL_ENSURE(constraint.Value().IsValid());
bool shouldEvaluate = (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вроде норм, но не до конца есть понимание нужно ли тут настолько strict условие. Что если просто проверить, что если там не data consturctor, то навесить EvaluateExpr?

@gridnevvvit gridnevvvit merged commit 449285f into ydb-platform:main Feb 9, 2024
2 of 4 checks passed
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
This was referenced Feb 12, 2024
Merged
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@serbel324 serbel324 mentioned this pull request Feb 13, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
@serbel324 serbel324 mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
Merged
gridnevvvit added a commit to gridnevvvit/ydb that referenced this pull request Feb 21, 2024
@gridnevvvit
support cast in default values (ydb-platform#1754)
b0361a9
This was referenced Feb 21, 2024
Merged
Merged
@gridnevvvit gridnevvvit deleted the support-casts-in-default-values branch March 19, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spuchin spuchin spuchin left review comments

@qrort qrort qrort left review comments

@dcherednik dcherednik dcherednik approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gridnevvvit @dcherednik @spuchin @qrort