Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize grpcpp includes #3681

Merged
merged 2 commits into from
May 15, 2024

Conversation

georgthegreat
Copy link
Contributor

@georgthegreat georgthegreat commented Apr 11, 2024

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

include/grpc++ was the original directory name for all C++ header files but it conflicted with the naming scheme required for some build systems. It is superseded by include/grpcpp but the old directory structure is still present to avoid breaking code that used the old include files. All new include files are only in include/grpcpp.

(cite is from grpc's own README.md).

Copy link

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

@maximyurchuk maximyurchuk added the ok-to-test Special label used to approve a PR for testing on our infrastructure label May 15, 2024
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label May 15, 2024
Copy link

github-actions bot commented May 15, 2024

2024-05-15 10:08:38 UTC Pre-commit check for 2c89121 has started.
2024-05-15 10:08:41 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-15 10:46:10 UTC Build successful.
2024-05-15 10:48:02 UTC Tests are running...
🔴 2024-05-15 12:46:05 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
69528 56858 0 5 12657 8

Copy link

github-actions bot commented May 15, 2024

2024-05-15 10:08:46 UTC Pre-commit check for 2c89121 has started.
2024-05-15 10:08:49 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-15 10:45:06 UTC Build successful.
2024-05-15 10:46:59 UTC Tests are running...
🔴 2024-05-15 12:29:14 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10707 10616 0 38 44 9

Copy link

github-actions bot commented May 15, 2024

2024-05-15 10:09:08 UTC Pre-commit check for 2c89121 has started.
2024-05-15 10:09:11 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-15 10:45:01 UTC Build successful.

@maximyurchuk maximyurchuk self-requested a review May 15, 2024 10:15
@maximyurchuk maximyurchuk merged commit 46f9e36 into ydb-platform:main May 15, 2024
4 of 6 checks passed
naspirato pushed a commit to naspirato/ydb that referenced this pull request May 15, 2024
MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request May 28, 2024
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
This was referenced Jun 7, 2024
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants