Disable spilling in LastWideCombiner if input or state is not serializable (currently has Resource type). #4590
Conversation
…zable (has type Resource)
| @@ -1523,6 +1530,10 @@ using TBaseComputation = TStatefulWideFlowCodegeneratorNode<TWideLastCombinerWra | |||
| #endif | |||
| }; | |||
|
|
|||
| bool IsTypeSerializable(const TType* type) { | |||
| return !type->IsResource(); | |||
There was a problem hiding this comment.
As far as I understand there are more non-serializable types.
Here are all possible types:
ydb/ydb/library/yql/minikql/mkql_node.h
Line 131 in f2efea6
And all the types that are not listed here are non-serializable:
Also, I think we can use ctx.Mutables.SerializableValues to get indexes of serializable values
There was a problem hiding this comment.
Thank you and I agree with you. Will add.
|
⚪
|
|
⚪
|
Fix overriding allowSpilling flag.
|
⚪
|
|
⚪
|
Changelog entry
Disable spilling in LastWideCombiner if input or state is not serializable (currently has Resource type).
Changelog category
Additional information
...