You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log cutting logic in HugeBlob keeper was someplace excessive and someplace incorrect. Now it is fixed. Under the new approach, only EntryPointLsn matters when choosing what to keep in log, but also volatile in-flight states for HugeBlobLogLsn and LSM tree entrypoints with FreedHugeBlobs vector. Upon recovery, all items are read in correct order and volatile state does not contribute in the correctness.
⚪ 2024-05-16 11:49:27 UTC Pre-commit check for f8c4004 has started.
⚪ 2024-05-16 11:49:29 UTC Build linux-x86_64-release-asan is running...
🔴 2024-05-16 11:51:29 UTC Build failed. see the build logs.
🔴 2024-05-16 11:52:59 UTC Tests run skipped.
⚪ 2024-05-16 13:16:25 UTC Pre-commit check for f8c4004 has started.
⚪ 2024-05-16 13:16:27 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-05-16 13:18:39 UTC Build failed. see the build logs.
⚪ 2024-05-16 13:19:34 UTC Pre-commit check for f8c4004 has started.
⚪ 2024-05-16 13:19:35 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-05-16 13:21:45 UTC Build failed. see the build logs.
🔴 2024-05-16 13:23:15 UTC Tests run skipped.
⚪ 2024-05-16 16:57:12 UTC Pre-commit check for 573dace has started.
⚪ 2024-05-16 16:57:15 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-05-16 17:02:12 UTC Check cancelled
⚪ 2024-05-16 16:57:16 UTC Pre-commit check for 573dace has started.
⚪ 2024-05-16 16:57:18 UTC Build linux-x86_64-release-clang14 is running...
⚫ 2024-05-16 17:02:12 UTC Check cancelled
⚪ 2024-05-16 16:57:21 UTC Pre-commit check for 573dace has started.
⚪ 2024-05-16 16:57:23 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-05-16 17:02:12 UTC Check cancelled
⚪ 2024-05-16 17:03:38 UTC Pre-commit check for c56207d has started.
⚪ 2024-05-16 17:03:39 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-16 17:36:39 UTC Build successful.
⚪ 2024-05-16 17:38:34 UTC Tests are running...
🔴 2024-05-16 19:34:17 UTC Some tests failed, follow the links below.
⚪ 2024-05-16 17:06:02 UTC Pre-commit check for c56207d has started.
⚪ 2024-05-16 17:06:04 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-16 17:36:43 UTC Build successful.
⚪ 2024-05-16 17:06:11 UTC Pre-commit check for c56207d has started.
⚪ 2024-05-16 17:06:15 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-16 17:40:52 UTC Build successful.
⚪ 2024-05-16 17:42:54 UTC Tests are running...
🔴 2024-05-16 19:25:20 UTC Some tests failed, follow the links below.
⚪ 2024-05-16 20:46:29 UTC Pre-commit check for 9707484 has started.
⚪ 2024-05-16 20:46:32 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-16 20:50:32 UTC Build successful.
⚪ 2024-05-16 20:46:39 UTC Pre-commit check for 9707484 has started.
⚪ 2024-05-16 20:46:42 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-16 20:50:37 UTC Build successful.
⚪ 2024-05-16 20:52:33 UTC Tests are running...
🔴 2024-05-16 22:39:12 UTC Some tests failed, follow the links below.
⚪ 2024-05-16 20:46:52 UTC Pre-commit check for 9707484 has started.
⚪ 2024-05-16 20:46:55 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-16 20:50:55 UTC Build successful.
⚪ 2024-05-16 20:52:51 UTC Tests are running...
🔴 2024-05-16 22:50:28 UTC Some tests failed, follow the links below.
⚪ 2024-05-17 08:36:17 UTC Pre-commit check for 458c39f has started.
⚪ 2024-05-17 08:36:20 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-17 09:07:21 UTC Build successful.
⚪ 2024-05-17 09:09:19 UTC Tests are running...
🔴 2024-05-17 10:39:03 UTC Some tests failed, follow the links below.
⚪ 2024-05-17 08:36:17 UTC Pre-commit check for 458c39f has started.
⚪ 2024-05-17 08:36:20 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-17 09:08:12 UTC Build successful.
⚪ 2024-05-17 08:36:19 UTC Pre-commit check for 458c39f has started.
⚪ 2024-05-17 08:36:22 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-17 09:08:03 UTC Build successful.
⚪ 2024-05-17 09:09:59 UTC Tests are running...
🔴 2024-05-17 11:02:02 UTC Some tests failed, follow the links below.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alexvru
force-pushed
the
vdisk/fix-huge-blob-keeper-log-cutting
branch
from
Changelog entry
Fix HugeBlob keeper log cutting logic
Changelog category
Additional information
Log cutting logic in HugeBlob keeper was someplace excessive and someplace incorrect. Now it is fixed. Under the new approach, only EntryPointLsn matters when choosing what to keep in log, but also volatile in-flight states for HugeBlobLogLsn and LSM tree entrypoints with FreedHugeBlobs vector. Upon recovery, all items are read in correct order and volatile state does not contribute in the correctness.