You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error indicator raised by the Python runtime, when the particular numeric cast fails, should be reset, when the exception is considered "handled" (e.g. rethrow of the unsuccessful cast error). PyErr_Clear had been lost since the very first commit, related to the Python bindings, i.e. 93acd0b ("Move YQL python UDFs in OS (#4139)"), though the similar exceptions are handled right in the "test" helpers (see TRY_FROM_PYTHON_FLOAT and TRY_FROM_PYTHON_LONG).
Considering the changes related to the Python integral types between 2.x and 3.x major releases, it's enough (almost) to provide only the one test for PyObject-to-int/long conversion.
⚪ 2024-05-20 18:49:56 UTC Pre-commit check for f5801e9 has started.
⚪ 2024-05-20 18:49:59 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-20 18:52:22 UTC Build successful.
⚪ 2024-05-20 18:50:00 UTC Pre-commit check for f5801e9 has started.
⚪ 2024-05-20 18:50:03 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-20 18:52:33 UTC Build successful.
⚪ 2024-05-20 18:54:01 UTC Tests are running...
🟢 2024-05-20 18:54:41 UTC Tests successful.
⚪ 2024-05-20 18:50:08 UTC Pre-commit check for f5801e9 has started.
⚪ 2024-05-20 18:50:10 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-20 18:52:27 UTC Build successful.
⚪ 2024-05-20 18:53:52 UTC Tests are running...
🟢 2024-05-20 18:54:36 UTC Tests successful.
The error indicator raised by the Python runtime, when the particular
numeric cast fails, should be reset, when the exception is considered
"handled" (e.g. rethrow of the unsuccessful cast error). <PyErr_Clear>
had been lost since the very first commit, related to the Python
bindings, i.e. 93acd0b ("Move YQL python UDFs in OS (ydb-platform#4139)"),
though the similar exceptions are handled right in the "test" helpers
(see <TRY_FROM_PYTHON_FLOAT> and <TRY_FROM_PYTHON_LONG>).
Considering the changes related to the Python integral types between 2.x
and 3.x major releases, it's enough (almost) to provide only the one
test for PyObject-to-int/long conversion.
Follows up ydb-platform#4139
⚪ 2024-05-20 20:42:02 UTC Pre-commit check for 1cfaa62 has started.
⚪ 2024-05-20 20:42:04 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-20 20:43:31 UTC Build successful.
⚪ 2024-05-20 20:44:58 UTC Tests are running...
🟢 2024-05-20 20:45:37 UTC Tests successful.
⚪ 2024-05-20 20:42:08 UTC Pre-commit check for 1cfaa62 has started.
⚪ 2024-05-20 20:42:11 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-20 20:45:19 UTC Build successful.
⚪ 2024-05-20 20:42:18 UTC Pre-commit check for 1cfaa62 has started.
⚪ 2024-05-20 20:42:20 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-20 20:43:47 UTC Build successful.
⚪ 2024-05-20 20:45:12 UTC Tests are running...
🟢 2024-05-20 20:46:03 UTC Tests successful.
Considering the difference between Python 2.x and Python 3.x regarding
the long integral types behaviour change, the patch adjusts the test
function payload to trigger the same exception for both major versions.
Follows up ydb-platform#4699
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
igormunkin
force-pushed
the
YQL-18435-fix-pyerr-rethrow-misuse
branch
from
The error indicator raised by the Python runtime, when the particular numeric cast fails, should be reset, when the exception is considered "handled" (e.g. rethrow of the unsuccessful cast error).
PyErr_Clearhad been lost since the very first commit, related to the Python bindings, i.e. 93acd0b ("Move YQL python UDFs in OS (#4139)"), though the similar exceptions are handled right in the "test" helpers (seeTRY_FROM_PYTHON_FLOATandTRY_FROM_PYTHON_LONG).Considering the changes related to the Python integral types between 2.x and 3.x major releases, it's enough (almost) to provide only the one test for PyObject-to-int/long conversion.
Follows up #4139
Changelog category