Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only give counter resource to tablets that never had normal metrics #4763

Merged
merged 2 commits into from
May 23, 2024
Merged

only give counter resource to tablets that never had normal metrics #4763

merged 2 commits into from
May 23, 2024

Conversation

vporyadke
Copy link
Collaborator

Changelog entry

only give counter resource to tablets that never had normal metrics

Changelog category

  • Improvement

Additional information

Counter-balancing was introduced with columnshards in mind and may be undesirable for other tablets.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 22, 2024 •
edited
Loading

⚪ 2024-05-22 19:03:27 UTC Pre-commit check for 64447f6 has started.
⚪ 2024-05-22 19:03:29 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-22 19:32:50 UTC Build successful.
⚪ 2024-05-22 19:34:43 UTC Tests are running...
🔴 2024-05-22 21:37:32 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10683 10612 0 35 27 9

@github-actions GitHub Actions
Copy link

github-actions bot commented May 22, 2024 •
edited
Loading

⚪ 2024-05-22 19:04:20 UTC Pre-commit check for 64447f6 has started.
⚪ 2024-05-22 19:04:22 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-22 19:33:23 UTC Build successful.
⚪ 2024-05-22 19:35:10 UTC Tests are running...
🔴 2024-05-22 21:10:21 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38153 33350 0 8 4786 9

@github-actions GitHub Actions
Copy link

github-actions bot commented May 22, 2024 •
edited
Loading

⚪ 2024-05-22 19:04:33 UTC Pre-commit check for 64447f6 has started.
⚪ 2024-05-22 19:04:35 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-22 19:31:39 UTC Build successful.

adameat
adameat reviewed May 23, 2024
View reviewed changes
ydb/core/util/metrics.h
@@ -395,6 +395,9 @@ class TMaximumValueVariableWindowUI64 : public NKikimrMetricsProto::TMaximumValu
using TProto = NKikimrMetricsProto::TMaximumValueUI64;

void SetValue(TType value, TInstant now = TInstant::Now()) {
if (TProto::GetAllTimeMaximum() > 0 || MaximumValue > 0) { // ignoring initial value
Copy link
Member

@adameat adameat May 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't you put it into the end of the function?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's easier to make this check before we update MaximumValue
i want to ignore the initial value because it is set by hive, not actually reported by the tablet

adameat
adameat previously approved these changes May 23, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

⚪ 2024-05-23 10:03:17 UTC Pre-commit check for ec8226d has started.
⚪ 2024-05-23 10:05:57 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-23 10:34:30 UTC Build successful.
⚪ 2024-05-23 10:34:42 UTC Tests are running...
🔴 2024-05-23 12:30:47 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10803 10740 0 25 28 10

@github-actions GitHub Actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

⚪ 2024-05-23 10:03:24 UTC Pre-commit check for ec8226d has started.
⚪ 2024-05-23 10:06:03 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-23 10:36:58 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

⚪ 2024-05-23 10:03:52 UTC Pre-commit check for ec8226d has started.
⚪ 2024-05-23 10:06:31 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-23 10:33:53 UTC Build successful.
⚪ 2024-05-23 10:34:07 UTC Tests are running...
🔴 2024-05-23 12:06:04 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38276 33476 0 5 4789 6

@vporyadke vporyadke merged commit 5f22068 into ydb-platform:main May 23, 2024
3 of 5 checks passed
@serbel324 serbel324 mentioned this pull request May 24, 2024
Merged
vporyadke added a commit to vporyadke/ydb that referenced this pull request May 24, 2024
@vporyadke
only give counter resource to tablets that never had normal metrics (y…
6deb648 
…db-platform#4763)
@vporyadke vporyadke mentioned this pull request May 24, 2024
Merged
This was referenced May 27, 2024
Closed
Closed
Merged
MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request May 28, 2024
@vporyadke @MrLolthe1st
only give counter resource to tablets that never had normal metrics (y…
6efe6f4 
…db-platform#4763)
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
Merged
This was referenced May 29, 2024
Merged
Merged
This was referenced May 30, 2024
Merged
Closed
Closed
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 7, 2024
Merged
This was referenced Jun 10, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adameat adameat adameat approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vporyadke @adameat